-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use portable-atomic
to fix build on some 32-bit platforms
#484
Conversation
I think you missed some imports in the |
More in general, do you think it would be feasible to set something up in CI that would let us catch this? |
|
Added an armv5te test job using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! @chris-laplante any thoughts?
Looks good to me! |
Any chance to release a new version soon? Had to downgrade to 0.17 alpha releases to make it build on some 32-bit platforms. |
See #488. |
https://github.com/taiki-e/portable-atomic
Fixes #475